fix: log unhandled error even if its stack is empty #14619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
the-ress
force-pushed
the
log-errors-without-stack
branch
from
563745b to
eed1412
Compare
SimenB
approved these changes
Oct 13, 2023
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into an issue when jest (
jest --coverage --runInBand --testTimeout=120000) would stop with exit code 1 without any error message.Upon further investigation, I found it's caused by
uncaughtExceptionhandler inCoverageWorker.tsthat only logserr.stackand the error I was encountering didn't have any stack (it was set to an empty string).Test plan
I ran
jest --coverage --runInBand --testTimeout=120000again and the error message got printed to console as expected:I didn't find any automated tests covering this behavior and I can't think of a good way to implement one.